Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

All k8s watchers should get stopped when k8s processor is stopped #35495

Closed
ChrsMark opened this issue May 17, 2023 · 1 comment · Fixed by #35630
Closed

All k8s watchers should get stopped when k8s processor is stopped #35495

ChrsMark opened this issue May 17, 2023 · 1 comment · Fixed by #35630
Labels
needs_team Indicates that the issue/PR needs a Team:* label

Comments

@ChrsMark
Copy link
Member

At

beats/libbeat/processors/add_kubernetes_metadata/kubernetes.go

Line 305 in fb25982

func (k *kubernetesAnnotator) Close() error {
we need to make sure that all additional watchers (for nodes and namespaces) are stopped.

This might be the root cause for elastic/elastic-agent-autodiscover#41.

cc: @gizas @cmacknz @tommyers-elastic
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label May 17, 2023
@botelastic
Copy link

botelastic bot commented May 17, 2023

This issue doesn't have a Team:<team> label.

@ChrsMark ChrsMark mentioned this issue May 31, 2023
Merged
@ChrsMark ChrsMark changed the title All k8s watchers should stopped when k8s processor is stopped All k8s watchers should get stopped when k8s processor is stopped May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs_team Indicates that the issue/PR needs a Team:* label
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make sure k8s watchers close when closing k8s meta processor ChrsMark/beats
1 participant
@ChrsMark