Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Redis Prospector Configuration #4398

Closed
2 of 3 tasks
ruflin opened this issue May 26, 2017 · 6 comments
Closed
2 of 3 tasks

Create Redis Prospector Configuration #4398

ruflin opened this issue May 26, 2017 · 6 comments
Labels

Comments

@ruflin
Copy link
Member

ruflin commented May 26, 2017

In #4180 the redis prospector type was added. The documentation for the redis prospector type requires a change in the doc structure as it has completely different config options then the other prospector types.

  • Create docs structure
  • Add docs for redis prospector
  • Add fields.yml
@dedemorton
Copy link
Contributor

@ruflin I've opened an issue to discuss restructuring the Config section. There are other problems with that section that need to be resolved besides adding more prospector types: #4422

@tsg
Copy link
Contributor

tsg commented May 31, 2017

I'm working on making a redis module based on the redis prospector. It might be that we don't really need to document the redis prospector all that much, and just ask people to use the module. Does that make sense?

@ruflin
Copy link
Member Author

ruflin commented Jun 2, 2017

@tsg I think we will still need to document the basic config options somewhere as they are accessible through the config in the module.

I'm trying to think of a use case where people would not use the module, but couldn't find one so having most of the docs in the module SGTM.

@ruflin
Copy link
Member Author

ruflin commented Jun 2, 2017

@dedemorton Proposal looks good to me. I like that it also covers "multiple prospectors". There is probably some info also on the "prospector" overview page that explains what a prospector is.

@dedemorton
Copy link
Contributor

On a related note, I'm also adding info about the udp prospector. I agree that we need to have a better overview of prospectors and what's possible.

@ruflin ruflin removed the v6.0.0-GA label Feb 26, 2018
@dedemorton
Copy link
Contributor

dedemorton commented Mar 24, 2018

@ruflin Can we close this? Sorry it took me so long to get around to refactoring the prospector/input docs. :-(

@ruflin ruflin closed this as completed Mar 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants