Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port over modules collection script to golang #9130

Closed
ycombinator opened this issue Nov 16, 2018 · 4 comments · Fixed by #13468
Closed

Port over modules collection script to golang #9130

ycombinator opened this issue Nov 16, 2018 · 4 comments · Fixed by #13468
Labels
Metricbeat Metricbeat module refactoring Team:Integrations Label for the Integrations team

Comments

@ycombinator
Copy link
Contributor

We are trying to move away from Python scripts called from Makefiles to golang scripts called from magefiles. Currently the modules collection script in Metricbeat is written in Python. It should be ported over to a golang script.

@andrewkroh
Copy link
Member

I did some of this for x-pack/filebeat to prove that it works, but none of it has been applied to other Beats. For example this creates the module.d directory

func createDirModulesD() error {

If this is something that you can reuse then generalize it and move it into dev-tools/mage/.

So some things have been ported over, but the old python/make version hasn't yet been replaced.

@ycombinator
Copy link
Contributor Author

Cool, thanks for the pointer @andrewkroh. I'll definitely look into it and try to generalize it. For a bit more context, this issue spun out of this conversation: #9118 (comment)

@jsoriano
Copy link
Member

I think @sayden was also migrating some things to Go.

@sayden
Copy link
Contributor

sayden commented Nov 16, 2018

Thanks for the heads up @jsoriano

Yeah, I started a backwards compatible PR that covers quite a lot of things by modifying "as little as possible" to make the build system work in x-pack metricbeat but I haven't tried to write anything from scratch, I've just modified what we have now to have something working ASAP.

I did this changes to the modules collector script but feel free to change whatever you need with magefiles, I'll update my branch later, all in all I know that part of my work is going to be just useful for a short period of time because @andrewkroh is doing a huge work to port everything to Go already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Metricbeat Metricbeat module refactoring Team:Integrations Label for the Integrations team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants