Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify -waitstop and shutdown_timeout #3588

Closed
ruflin opened this issue Feb 14, 2017 · 2 comments
Closed

Unify -waitstop and shutdown_timeout #3588

ruflin opened this issue Feb 14, 2017 · 2 comments
Labels
enhancement help wanted Indicates that a maintainer wants help on an issue or pull request Metricbeat Metricbeat Packetbeat

Comments

@ruflin
Copy link
Contributor

ruflin commented Feb 14, 2017

Filebeat has a shutdown_timeout config option and packetbeat a -waitstop option. These two should be unified into 1 option.
@monicasarbu monicasarbu added the help wanted Indicates that a maintainer wants help on an issue or pull request label Feb 16, 2017
@glefloch
Copy link
Contributor

In your opinion, which option should we keep? The one from config file or the one from argument command line?

Can this be added to common config?

@ruflin
Copy link
Contributor Author

ruflin commented Apr 24, 2017

I think we should keep the shutdown_timeout as the options should also be part of the config. If we can generalise the concept, it should also be part of the common config, but that means it must happen in libbeat.

@glefloch glefloch mentioned this issue Apr 25, 2017
Merged
ruflin pushed a commit that referenced this issue May 16, 2017
@glefloch @ruflin
Unify shutdown timeout (#4107)
cf92660 
This pull request aims to unify shutdown timeout.
For now, this is must be implemented in each beat Run method due to specific code in filebeat.

Close #3588
@tsg tsg mentioned this issue Jul 24, 2017
Closed
28 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted Indicates that a maintainer wants help on an issue or pull request Metricbeat Metricbeat Packetbeat
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ruflin @glefloch @monicasarbu