Dialer is broken in e2e tests

[barkbay]

dialer is broken in e2e tests.
I think it comes from e1a3023#diff-fcadcd8abc54d908e7568bc91579f44fL31

The namespace is needed in the url in order to get the pod with the RESTClient and without the svc it's trying to forward to a pod and not to a service.

[thbkrkr]

This happens when using --auto-port-forward.

The custom dev port forwarder expects that a pod address is composed of three parts <name>.<namespace>.svc:

cloud-on-k8s/operators/pkg/dev/portforward/pod_forwarder.go

Lines 118 to 124 in 03fad11

	// retrieve pod name and namespace from addr
	// TODO: subdomains in pod names would change this.
	parts := strings.SplitN(host, ".", 3)
	if len(parts) <= 2 {
	return nil, fmt.Errorf("unsupported pod address format: %s", host)
	}
	return &types.NamespacedName{Namespace: parts[1], Name: parts[0]}, nil

[sebgl]

I guess we can either:

1. Revert the e2e change to keep using name.namespace.svc
2. Modify the port forward code to be able to forward name only

I'd vote for 2.

[thbkrkr]

2. Modify the port forward code to be able to forward name only

Do not we also need the namespace?

[sebgl]

Our quickstart doc advertises reaching the service from its name only (no namespace, no .svc extension):

Get access to Elasticsearch.
From the Kubernetes cluster, use this URL:
https://quickstart-es:9200

However this longer-term E2E tests will probably work across multiple namespaces I guess it's fine to include the namespace here. With no namespace it's almost impossible to know where to redirect the call from the custom dialer code perspective anyway. tl;dr: you're right 👍