Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn the user about NodeSpec PVC resize not possible #1293

Closed
Tracked by #1299
sebgl opened this issue Jul 19, 2019 · 0 comments · Fixed by #1517
Closed
Tracked by #1299

Warn the user about NodeSpec PVC resize not possible #1293

sebgl opened this issue Jul 19, 2019 · 0 comments · Fixed by #1517
Assignees
@anyasabo
Labels
good first issue Good for newcomers justdoit Continuous improvement not related to a specific feature

Comments

@sebgl
Copy link
Contributor

sebgl commented Jul 19, 2019

A limitation of StatefulSets is that we cannot resize the PersistentVolumeClaimTemplate section of its spec.
Hence user cannot edit the PersistentVolumeClaim section of the NodeSpec.

This is not obvious for the user.

We could:

  • reject the update in the admission webhook
  • log an error if that happens
  • emit an event if that happens

Related: #325
@sebgl sebgl added justdoit Continuous improvement not related to a specific feature loe:medium labels Jul 19, 2019
@sebgl sebgl mentioned this issue Jul 19, 2019
Closed
18 tasks
@pebrc pebrc added the good first issue Good for newcomers label Aug 5, 2019
@anyasabo anyasabo self-assigned this Aug 6, 2019
This was referenced Aug 7, 2019
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@anyasabo anyasabo

Labels
good first issue Good for newcomers justdoit Continuous improvement not related to a specific feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add webhook check for PVC modification anyasabo/cloud-on-k8s
3 participants
@pebrc @sebgl @anyasabo