Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup corrected ES naming length conventions #1474

Closed
sebgl opened this issue Aug 5, 2019 · 1 comment · Fixed by #1647
Closed

Setup corrected ES naming length conventions #1474

sebgl opened this issue Aug 5, 2019 · 1 comment · Fixed by #1647
Assignees
Labels
justdoit Continuous improvement not related to a specific feature

Comments

@sebgl
Copy link
Contributor

sebgl commented Aug 5, 2019

We don't have to name pods anymore, and our naming length conventions were based on computing cluster name +pod suffix + longest secret per pod suffix.

We now manipulate secrets like:

  • cluster name - es - nodespec name - config
  • cluster name - es - transport-certs-public

We should come up with proper length restrictions for both the cluster name and the nodespec name.

@charith-elastic
Copy link
Contributor

charith-elastic commented Aug 30, 2019

There was some discussion about this in #1647 and the results of the following investigation is as follows. Note that the code base is huge and it is not possible to find all the places where names are concatenated with other suffixes and prefixes so this list is probably not exhaustive.

suffix length
-es-transport-certificates 26
-es-transport-ca-internal 25
-es-transport-ca-public 23
-es-xpack-file-realm 20
-es-http-ca-internal 20
-es-internal-users 18
-es-http-ca-public 18
-es-unicast-hosts 17
-es-elastic-user 16
-kb-kibana-user 15
-apm-apm-es-ca 14
-apm-apm-user 13
-kb-kb-es-ca 12
-es-scripts 11
-es-license 11
-es-default 11
-es-http 8
-es-<nodeSpec name> 4+?
-es-<nodeSpec name>-config ?+11

Only the Elasticsearch name and SSet name (ES+nodeSpec) seems to be used as labels. Therefore, we can probably keep the existing ES name length restriction of 36 but extend the nodeSpec name length restriction from 19 to 23 (63-36-4).

Actions

  • Increase nodeSpec name length to 23
  • Add E2E test to exercise the path where names are at their maximum length

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
justdoit Continuous improvement not related to a specific feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants