Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure validating webhook work fine for both crd v1beta1 and crd v1 #2221

Closed
sebgl opened this issue Dec 6, 2019 · 1 comment
Closed

Ensure validating webhook work fine for both crd v1beta1 and crd v1 #2221

sebgl opened this issue Dec 6, 2019 · 1 comment
Labels
justdoit Continuous improvement not related to a specific feature

Comments

@sebgl
Copy link
Contributor

sebgl commented Dec 6, 2019

#2184 introduces CRD v1, with validating webhooks enabled for both v1beta1 and v1.
I have some doubts both work as expected, let's double check.
@sebgl sebgl added the justdoit Continuous improvement not related to a specific feature label Dec 6, 2019
@sebgl sebgl mentioned this issue Dec 6, 2019
Merged
@sebgl
Copy link
Contributor Author

sebgl commented Dec 12, 2019

Deploy an Elasticsearch resource with 0 nodeSets in version v1: webhook successfully rejects the creation.
Deploy an Elasticsearch resource with 0 nodeSets in version v1beta1: webhook successfully rejects the creation.

I think we're all god, I'm closing the issue.

@sebgl sebgl closed this as completed Dec 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
justdoit Continuous improvement not related to a specific feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sebgl