Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review version validation code #2789

Open
charith-elastic opened this issue Mar 31, 2020 · 0 comments
Open

Review version validation code #2789

charith-elastic opened this issue Mar 31, 2020 · 0 comments
Labels
>enhancement Enhancement of existing functionality

Comments

@charith-elastic
Copy link
Contributor

charith-elastic commented Mar 31, 2020

Things to address here are:

  • Find a way to have supported versions defined in a single place. Elasticsearch supported versions are in pkg/controller/elasticsearch/version whereas the other resources have their supported versions defined in pkg/controller/common/version. The advantage of having all supported versions declared in a single place is that it leaves less room for errors when updating the upper and lower bounds as the Stack evolves.
  • Current checks do not allow version downgrades even at the patch level (e.g. going from 7.6.1 to 7.6.0 is not allowed). I don't think there's a good reason for this as semver principles do allow it.
  • Consider whether we want to implement the support matrix.
  • Consider whether we want to enforce the upgrade order in the webhook.

Follow-up from #2781

@charith-elastic charith-elastic added the >enhancement Enhancement of existing functionality label Mar 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>enhancement Enhancement of existing functionality
Projects
None yet
Development

No branches or pull requests

1 participant