Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce the number of calls to _cluster/settings in a single reconciliation #3248

Open
sebgl opened this issue Jun 15, 2020 · 0 comments
Open

Reduce the number of calls to _cluster/settings in a single reconciliation #3248

sebgl opened this issue Jun 15, 2020 · 0 comments
Labels
>enhancement Enhancement of existing functionality

Comments

@sebgl
Copy link
Contributor

sebgl commented Jun 15, 2020

In a regular no-op reconciliation when no change happens we perform several calls to _cluster/settings:

  • GET /_cluster/settings to fetch remote clusters configuration
  • PUT /_cluster/settings to set zen1 minimum_master_nodes
  • PUT /_cluster/settings to reset cluster routing allocation excludes to none when there are no nodes to migrate data away from
  • GET /_cluster/settings to know whether we need to re-enable shards allocation after a rolling upgrade

Could we optimize to a single GET from which we reuse the result during the reconciliation, and don't do the PUTs if not required?
@sebgl sebgl added the >enhancement Enhancement of existing functionality label Jun 15, 2020
@sebgl sebgl mentioned this issue Jun 18, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
>enhancement Enhancement of existing functionality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sebgl