Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No need for ?jvm when retrieving the list of nodes #3249

Closed
sebgl opened this issue Jun 15, 2020 · 0 comments · Fixed by #3860
Closed

No need for ?jvm when retrieving the list of nodes #3249

sebgl opened this issue Jun 15, 2020 · 0 comments · Fixed by #3860
Assignees
@pebrc
Labels
>enhancement Enhancement of existing functionality

Comments

@sebgl
Copy link
Contributor

sebgl commented Jun 15, 2020

We call GET /_nodes/_all/jvm,settings to retrieve the list of nodes in the cluster, and their roles.
The response has a lot of details we don't need within a reconciliation, and seems only used inside E2E tests.
We should probably split this into 2 different functions:

  • one that simply lists the nodes (what's the best API call for that?) for the operator
  • another one that retrieves jvm settings for E2E tests purposes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pebrc pebrc

Labels
>enhancement Enhancement of existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove unnecessary metrics from _nodes ES API request pebrc/cloud-on-k8s
2 participants
@pebrc @sebgl