Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updateStrategy support for Beat CRD #3839

Closed
Sayrus opened this issue Oct 14, 2020 · 1 comment · Fixed by #4049
Closed

updateStrategy support for Beat CRD #3839

Sayrus opened this issue Oct 14, 2020 · 1 comment · Fixed by #4049
Assignees
Labels
>enhancement Enhancement of existing functionality v1.4.0

Comments

@Sayrus
Copy link

Sayrus commented Oct 14, 2020

Proposal

Add support for updateStrategy on Beat CRD. Currently, only the PodTemplate (And replicas on a Deployment) can be modified.

PodTemplate: rp.podTemplate,

Use case. Why is this important?
When rolling out a Beat (Filebeat in our case) on large clusters (especially when using DaemonSet), the default updateStrategy's maxUnavailable: 1 increases rollout times. In the case of Filebeat, unless the configuration is invalid, we can actually afford to rollover most of the pods (as long as the burst can be ingested by the ES after rollout).

Note
At first, I thought that daemonSet was mostly passed to the daemonSet itself as the fields description is:

Daemon Set:
  Description:  DaemonSet specifies the Beat should be deployed as a DaemonSet, and allows providing its spec. Cannot be used along with `deployment`. If both are absent a default for the Type is used.

However, as I searched in the code, it does not seem like we are actually allowed to provide any spec for the DaemonSet itself and also had a hard time finding documentation on what fields are allowed inside this daemonSet field. Is there any need for help on this subject?

@botelastic botelastic bot added the triage label Oct 14, 2020
@david-kow david-kow added the >enhancement Enhancement of existing functionality label Oct 14, 2020
@botelastic botelastic bot removed the triage label Oct 14, 2020
@Sayrus Sayrus changed the title PDB support for Beat CRD updateStrategy support for Beat CRD Oct 30, 2020
@Sayrus
Copy link
Author

Sayrus commented Oct 30, 2020

For some reason, I wrote PDB when I meant updateStrategy, sorry about that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>enhancement Enhancement of existing functionality v1.4.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants