Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promote EnterpriseSearch to v1 #4257

Closed
pebrc opened this issue Feb 18, 2021 · 2 comments · Fixed by #4284
Closed

Promote EnterpriseSearch to v1 #4257

pebrc opened this issue Feb 18, 2021 · 2 comments · Fixed by #4284
Assignees

Comments

@pebrc
Copy link
Collaborator

pebrc commented Feb 18, 2021

What is the impact for existing users on all supported platforms e.g. OpenShift 3.11

Let's promote the EnterpriseSearch CRD to v1 given that we consider it to have reached GA status and we consider the API stable at this point.

@pebrc
Copy link
Collaborator Author

pebrc commented Feb 25, 2021

Doing some GH archaeology, we ran into issues with older versions of k8s mainly v1.11 and unpatched versions of 1.12 and 1.13

Underlying kubernetes/kubernetes#73752

#2308 has the relevant ECK discussion from back then. We decided to recommended reinstalling all custom resources back then for users on affected k8s versions. This was acceptable back then as ECK was still alpha. We cannot use the same approach this time round.

Options as I see them:

  • do not upgrade the API schema version
  • do upgrade the API schema version but document that users on older versions of k8s will have to disable the webhook or to change the API version of existing resources back to v1beta1 by manual edit
  • wait with this change until we don't have to support the older k8s versions anymore

@pebrc
Copy link
Collaborator Author

pebrc commented Mar 1, 2021

The impact of migrating to v1 is somewhat limited by the fact that patched k8s versions exist for > 1.12 and that OpenShift 3.11 by default has the validating admission webhook disabled. So that documenting the workaround for the small number of users potentially affected seems like a viable option.

@pebrc pebrc changed the title Investigate EnterpriseSearch upgrade to v1 Promote EnterpriseSearch to v1 Mar 1, 2021
@thbkrkr thbkrkr self-assigned this Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants