Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elasticsearch HTTP client: log requests at debug level #4935

Closed
barkbay opened this issue Oct 8, 2021 · 2 comments · Fixed by #4958
Closed

Elasticsearch HTTP client: log requests at debug level #4935

barkbay opened this issue Oct 8, 2021 · 2 comments · Fixed by #4958
Assignees
Labels
>enhancement Enhancement of existing functionality good first issue Good for newcomers v1.9.0

Comments

@barkbay
Copy link
Contributor

barkbay commented Oct 8, 2021

As mentioned in this comment we should log (at the debug level) all the requests to Elasticsearch.
We should take care to not log the body or any header as they may contain some credentials. The debug log should also contain the Elasticsearch cluster namespaced name as for the other logs (es_name).

@barkbay barkbay added the good first issue Good for newcomers label Oct 8, 2021
@botelastic botelastic bot added the triage label Oct 8, 2021
@barkbay barkbay added v1.9.0 and removed triage labels Oct 8, 2021
@botelastic botelastic bot added the triage label Oct 8, 2021
@barkbay barkbay added >enhancement Enhancement of existing functionality and removed triage labels Oct 8, 2021
@koneko096
Copy link
Contributor

let me try

@barkbay
Copy link
Contributor Author

barkbay commented Oct 14, 2021

@koneko096 Hi 👋 , let me know if you have any issue/question, we would like to have this one in the next release.
Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>enhancement Enhancement of existing functionality good first issue Good for newcomers v1.9.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants