ApmServer secret token config is invalid for APM Server 8.0+

[axw]

cloud-on-k8s/pkg/controller/apmserver/config.go

Line 30 in f826719

APMServerSecretToken = "apm-server.secret_token" //nolint:gosec

ECK is setting outdated configuration for the APM secret token, that was removed in APM Server 8.0 (https://www.elastic.co/guide/en/apm/guide/current/release-notes-8.0.html#_breaking_changes_7). This should be updated to apm-server.auth.secret_token for 8.0+

The outcome of this bug is that, by default, APM Server has no secret token auth configured.

[pebrc]

@barkbay I think we should try to fix this for the upcoming 2.8 release wdyt?

[barkbay]

@barkbay I think we should try to fix this for the upcoming 2.8 release wdyt?

Yes 👀