Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Propagate more podTemplate fields into the final pods #765

Closed
sebgl opened this issue May 7, 2019 · 3 comments
Closed

Propagate more podTemplate fields into the final pods #765

sebgl opened this issue May 7, 2019 · 3 comments
Assignees
@sebgl
Labels
>enhancement Enhancement of existing functionality

Comments

@sebgl
Copy link
Contributor

sebgl commented May 7, 2019

So far, users are allowed to use podTemplate to propagate:

  • labels
  • affinity
  • resources limits

We should extend that behaviour to more fields of the provided pod template.
@sebgl sebgl changed the title Propagate more podTemplate fields into th Propagate more podTemplate fields into the final pods May 7, 2019
@sebgl sebgl added the >enhancement Enhancement of existing functionality label May 7, 2019
@sebgl sebgl added this to the Beta milestone May 7, 2019
@pebrc pebrc removed this from the Beta milestone May 10, 2019
@nkvoll
Copy link
Member

nkvoll commented May 25, 2019

Our intention now is to not copy a few whitelisted fields, but start out with the pod template from the spec when constructing the pods we need.

@nkvoll nkvoll mentioned this issue May 25, 2019
Closed
@sebgl sebgl self-assigned this May 26, 2019
@sebgl sebgl mentioned this issue May 27, 2019
Merged
@nkvoll
Copy link
Member

nkvoll commented Jun 8, 2019

Closed in #943

@nkvoll nkvoll closed this as completed Jun 8, 2019
@pebrc
Copy link
Collaborator

pebrc commented Jun 18, 2019

#952 fixes the Kibana side of this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sebgl sebgl

Labels
>enhancement Enhancement of existing functionality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nkvoll @pebrc @sebgl