Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Elasticearch readiness port instead of / for Pod readiness #7841

Closed
pebrc opened this issue May 23, 2024 · 2 comments · Fixed by #7847
Closed

Use Elasticearch readiness port instead of / for Pod readiness #7841

pebrc opened this issue May 23, 2024 · 2 comments · Fixed by #7847
Assignees
Labels
>bug Something isn't working sdh

Comments

@pebrc
Copy link
Collaborator

pebrc commented May 23, 2024

elastic/elasticsearch#50187 introduces a new readiness TCP endpoint we should use to determine pod readiness as it will take cluster membership into account https://www.elastic.co/guide/en/elasticsearch/reference/current/advanced-configuration.html#readiness-tcp-port

Our current readiness probe does call / which returns 200 before the node has joined a cluster. When rotating master nodes in quick succession through external means (so not through the rolling upgrade the ECK opererator orchestrates) for example a k8s cluster upgrade or cluster-autoscaler activity, the cluster might become unavailable for a few seconds because of that.

@pebrc pebrc added >bug Something isn't working sdh labels May 23, 2024
@pebrc pebrc self-assigned this May 24, 2024
@pebrc
Copy link
Collaborator Author

pebrc commented May 24, 2024

The readiness feature is available as of Elastic stack 8.2.0. The implementation should include an appropriate version gate

@pebrc
Copy link
Collaborator Author

pebrc commented May 27, 2024

Njal foresaw this issue way back in 2019 #916

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>bug Something isn't working sdh
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant