Service not reset when set then removed from definition

[thbkrkr]

ECK manages a set of services per Elasticsearch cluster that users can configure. By default, the operator configures the http service with typeClusterIP. If a user configures it with type LoadBalancer and later completely deletes it from the es resource definition, the service is never reconfigured to the default typeClusterIP.

Step to reproduce:

• Deploy an Elasticsearch with a LoadBalancer service:

apiVersion: elasticsearch.k8s.elastic.co/v1
kind: Elasticsearch
metadata:
  name: c0
spec:
  version: 8.15.3
  http:
    service:
      spec:
        type: LoadBalancer
  nodeSets:
  - name: default
    count: 1
    config:
      node.store.allow_mmap: false

• Remove the service from the definition and redeploy:

apiVersion: elasticsearch.k8s.elastic.co/v1
kind: Elasticsearch
metadata:
  name: c0
spec:
  version: 8.15.3
  # http:
  #   service:
  #     metadata:
  #       annotations:
  #         answer: "42"
  #     spec:
  #       type: LoadBalancer
  nodeSets:
  - name: default
    count: 1
    config:
      node.store.allow_mmap: false

• Check that the service type is still LoadBalancer:

NAME                  TYPE           CLUSTER-IP      EXTERNAL-IP    PORT(S)          AGE
c0-es-http            LoadBalancer   10.1.2.3   192.1.2.3   9200:31142/TCP   3m24s

Why?

We have a function to set the defaults, but we don't set the type there:

cloud-on-k8s/pkg/controller/common/defaults/service.go

Line 14 in 645f750

func SetServiceDefaults(

.

We have a function to applyServerSideValues for several reasons, to decide if we need to recreate or update the service, where we retrieve and restore the current reconciled type.

cloud-on-k8s/pkg/controller/common/service_control.go

Lines 53 to 54 in 645f750

	func needsRecreate(expected, reconciled *corev1.Service) bool {
	applyServerSideValues(expected, reconciled)

[thbkrkr]

I wonder what other default value than ClusterIP may be set (comes from #1011)?

cloud-on-k8s/pkg/controller/common/service_control.go

Lines 91 to 94 in 645f750

	// Type may be defaulted by the api server
	if expected.Spec.Type == "" {
	expected.Spec.Type = reconciled.Spec.Type
	}

Reading the godoc of the type field, it is written that it defaults to ClusterIP.

[kaykhan]

@thbkrkr

I wonder if i my issue is related at all - #8157

I remember not setting NodePort to begin with which would have defaulted to ClusterIP

But now that i want to set the http service as type NodePort it always spawns as ClusterIP

Is there any way around this?