Clarify data migration function and unit tests #2845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I got confused by the comment attached to the `IsMigratingData` function, along with its unit tests. They somehow indicate we're checking if a node has the only copy of a shard. But the reality is we just check if there's any shard on that node. This commit renames the function to `ShardsOnNode()`, modifies the comment accordingly, and adapt the unit tests to the very simple logic of the function.
pebrc
approved these changes
Apr 9, 2020
barkbay
pushed a commit
to barkbay/cloud-on-k8s
that referenced
this pull request
Apr 15, 2020
I got confused by the comment attached to the `IsMigratingData` function, along with its unit tests. They somehow indicate we're checking if a node has the only copy of a shard. But the reality is we just check if there's any shard on that node. This commit renames the function to `ShardsOnNode()`, modifies the comment accordingly, and adapt the unit tests to the very simple logic of the function.
barkbay
added a commit
that referenced
this pull request
Apr 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I got confused by the comment attached to the
IsMigratingDatafunction, along with its unit tests. They somehow indicate we're
checking if a node has the only copy of a shard.
But the reality is we just check if there's any shard on that node.
This commit renames the function to
ShardsOnNode(), modifies thecomment accordingly, and adapts the unit tests to the simple function logic.