Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove incorrect statement about specifying coordinating roles in YAML #4434

Merged
merged 1 commit into from
Apr 20, 2021

Conversation

pebrc
Copy link
Collaborator

@pebrc pebrc commented Apr 20, 2021

While we are not happy with the hack we added to address #3718 from a user point of view node.roles: [] works just fine. Where as !!seq "" never worked. Let's remove this note and update any affected examples.

@pebrc pebrc added >docs Documentation v1.5.0 v1.4.0 labels Apr 20, 2021
Copy link
Contributor

@sebgl sebgl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pebrc pebrc merged commit bf915b0 into elastic:master Apr 20, 2021
pebrc added a commit to pebrc/cloud-on-k8s that referenced this pull request Apr 20, 2021
elastic#4434)

# Conflicts:
#	docs/orchestrating-elastic-stack-applications/elasticsearch/node-configuration.asciidoc
pebrc added a commit to pebrc/cloud-on-k8s that referenced this pull request Apr 20, 2021
elastic#4434)

# Conflicts:
#	docs/orchestrating-elastic-stack-applications/elasticsearch/node-configuration.asciidoc
pebrc added a commit that referenced this pull request Apr 20, 2021
#4434) (#4438)

# Conflicts:
#	docs/orchestrating-elastic-stack-applications/elasticsearch/node-configuration.asciidoc
pebrc added a commit that referenced this pull request Apr 20, 2021
#4434) (#4437)

# Conflicts:
#	docs/orchestrating-elastic-stack-applications/elasticsearch/node-configuration.asciidoc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants