Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for RTL text #1432

Closed
nickofthyme opened this issue Oct 18, 2021 · 1 comment · Fixed by #1433
Closed

Support for RTL text #1432

nickofthyme opened this issue Oct 18, 2021 · 1 comment · Fixed by #1433
Labels
:all Applies to all chart types enhancement New feature or request :partition Partition/PieChart/Donut/Sunburst/Treemap chart related :styling Styling related issue

Comments

@nickofthyme
Copy link
Collaborator

nickofthyme commented Oct 18, 2021 •
edited
Loading

Is your feature request related to a problem? Please describe.
I'd like to allow a way to support RTL text in canvas to match the behavior in the tooltip.

Describe the solution you'd like
Manually set canvas dir attribute according to locale.
@nickofthyme nickofthyme added enhancement New feature or request :styling Styling related issue :partition Partition/PieChart/Donut/Sunburst/Treemap chart related :all Applies to all chart types labels Oct 18, 2021
@dej611
Copy link
Contributor

dej611 commented Oct 18, 2021

There's also the canvas dir attribute (which has wider browser support): https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/dir

@nickofthyme nickofthyme mentioned this issue Oct 18, 2021
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
:all Applies to all chart types enhancement New feature or request :partition Partition/PieChart/Donut/Sunburst/Treemap chart related :styling Styling related issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(partition): rtl text label support nickofthyme/elastic-charts
2 participants
@dej611 @nickofthyme