Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add color picker for legend item #23

Closed
3 tasks done
markov00 opened this issue Jan 31, 2019 · 3 comments · Fixed by #51
Closed
3 tasks done

Add color picker for legend item #23

markov00 opened this issue Jan 31, 2019 · 3 comments · Fixed by #51
Labels
enhancement New feature or request kibana cross issue Has a Kibana issue counterpart :legend Legend related issue released Issue released publicly

Comments

@markov00
Copy link
Member

markov00 commented Jan 31, 2019

Is your feature request related to a problem? Please describe.
Add a color picker to choose a new series color when clicking on the legend item.

Describe the solution you'd like
Will use EUIColorPicker

Describe alternatives you've considered

Additional context

Kibana Cross Issues
elastic/kibana#28618
elastic/kibana#19341

Checklist

  • this request is checked against already exist requests
  • every related Kibana issue is listed under Kibana Cross Issues list
  • kibana cross issue tag is associated to the issue if any kibana cross issue is present
@markov00 markov00 added the enhancement New feature or request label Jan 31, 2019
This was referenced Feb 18, 2019
@emmacunningham emmacunningham self-assigned this Feb 20, 2019
@markov00 markov00 added the :legend Legend related issue label Feb 28, 2019
@markov00 markov00 added this to the 7.1 milestone Feb 28, 2019
@emmacunningham emmacunningham added the kibana cross issue Has a Kibana issue counterpart label Feb 28, 2019
@markov00
Copy link
Member Author

markov00 commented Mar 6, 2019

🎉 This issue has been resolved in version 2.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@markov00 markov00 added the released Issue released publicly label Mar 6, 2019
@nickofthyme
Copy link
Collaborator

@markov00 & @rshen91 Do you think we could just require a React component, i.e. EuiColorPicker, to render allow this? I think it would look bad if the charts had a different color picker.

@rshen91
Copy link
Contributor

rshen91 commented Jan 30, 2020

@markov00 & @rshen91 Do you think we could just require a React component, i.e. EuiColorPicker, to render allow this? I think it would look bad if the charts had a different color picker.

I don't have a problem with this, and keeping the color pickers consistent makes sense to me. It looks like it already is a11y friendly so that's a plus elastic/eui#789

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request kibana cross issue Has a Kibana issue counterpart :legend Legend related issue released Issue released publicly
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants