Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align Legend design to K7 Design #34

Closed
markov00 opened this issue Feb 5, 2019 · 1 comment · Fixed by #54
Closed

Align Legend design to K7 Design #34

markov00 opened this issue Feb 5, 2019 · 1 comment · Fixed by #54
Labels
enhancement New feature or request released Issue released publicly

Comments

@markov00
Copy link
Member

markov00 commented Feb 5, 2019

With this PR: elastic/kibana#29896 the icon to collapse the legend is now always on the same place (bottom left) and disappear when moving the mouse focus out of the chart panel.
We need to align the current implementation with that style
@markov00 markov00 added the enhancement New feature or request label Feb 5, 2019
@markov00 markov00 mentioned this issue Feb 13, 2019
Merged
markov00 added a commit to markov00/elastic-charts that referenced this issue Feb 15, 2019
@markov00
refactor(legend): add margins and use new kibana legend toggle
830e564 
new the legend respect the chart theme margins. The toggle is now moved to the bottom left of the
chart as in kibana new design.

fix elastic#34
markov00 added a commit that referenced this issue Feb 15, 2019
@markov00
style(legend): align k7 design (#54)
80112a7 
The legend respect the chart theme margins. The toggle is now moved to the bottom left of the
chart as in kibana new design.
Added the euiScrollBar on legend.
Refactored the use of classnames package using object for the conditional class

fix #34
@markov00
Copy link
Member Author

🎉 This issue has been resolved in version 2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@markov00 markov00 added the released Issue released publicly label Feb 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request released Issue released publicly
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

style(legend): align k7 design markov00/elastic-charts
1 participant
@markov00