Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore commented lines in pipeline code coverage #2045

Open
ebeahan opened this issue Aug 27, 2024 · 3 comments
Open

Ignore commented lines in pipeline code coverage #2045

ebeahan opened this issue Aug 27, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@ebeahan
Copy link
Member

ebeahan commented Aug 27, 2024

Interested if it's possible to remove comment lines for the code coverage scoring for ingest pipelines.

As an example, the coverage score (65.7% when submitting) of this ingest pipeline is pulled down significantly with all the comment lines counting as uncovered code.

@ebeahan ebeahan added the enhancement New feature or request label Aug 27, 2024
@haetamoudi
Copy link
Contributor

Empty lines are also currently marked as 'uncovered code'. It would make sense to ignore them too

Image

@jsoriano
Copy link
Member

We'll take a look, maybe this is a regression from #1915.

@jsoriano
Copy link
Member

When generating the base coverage we can probably ignore empty lines and comments depending on the format.

We do this in:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants