Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Pass parameters to FacetedSearch #1627

Closed
MichZipp opened this issue Oct 4, 2022 · 1 comment
Closed

Feature Request: Pass parameters to FacetedSearch #1627

MichZipp opened this issue Oct 4, 2022 · 1 comment

Comments

@MichZipp
Copy link

MichZipp commented Oct 4, 2022

The Search object allows us to pass parameters such as the "request_timeout".
However, we cannot pass parameters to the FacetedSearch. Therefore, large requests will time out quickly.

We could easily integrate this feature by adding the following lines:

class FacetedSearch(object):
    ...
    params = None
    ...

   def search(self):
        s = Search(doc_type=self.doc_types, index=self.index, using=self.using).params(**self.params)
        return s.response_class(FacetedResponse)
   ...

I'm happy to do the changes and submit a pull request.

@miguelgrinberg
Copy link
Collaborator

Implemented in #1500, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants