From c9729539623ac6bed7c3e47010723c03ad06a84d Mon Sep 17 00:00:00 2001 From: lukasolson Date: Wed, 21 Jan 2015 15:40:42 -0700 Subject: [PATCH] Add 504 error handling and update contributing guide --- CONTRIBUTING.md | 2 +- src/lib/errors.js | 6 ++++++ 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 8c08bc74d..ae91846ec 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -33,7 +33,7 @@ Please write test cases to exercise your changes. Or to skip the integration tests: ```sh - grunt test_unit + grunt unit_test ``` 4. Optionally, run the browser tests. While this step is automated and simple, it can take several minutes for the tests to complete. Unless you are making changes to browser specific portions of the code you can probably let Travis run the browser tests for you. diff --git a/src/lib/errors.js b/src/lib/errors.js index 685ff1bf2..dda9b5311 100644 --- a/src/lib/errors.js +++ b/src/lib/errors.js @@ -79,6 +79,12 @@ _.inherits(errors.RequestTypeError, ErrorAbstract); var statusCodes = { + /** + * GatewayTimeout + * @param {String} [msg] - An error message that will probably end up in a log. + */ + 504: 'Gateway Timeout', + /** * ServiceUnavailable * @param {String} [msg] - An error message that will probably end up in a log.