Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENHANCEMENT] Retry API calls #37

Open
russcam opened this issue Dec 20, 2019 · 4 comments
Open

[ENHANCEMENT] Retry API calls #37

russcam opened this issue Dec 20, 2019 · 4 comments
Labels
enhancement New feature or request

Comments

@russcam
Copy link
Contributor

russcam commented Dec 20, 2019

All Elasticsearch clients are intended to retry API calls whose response is a 502, 503 or 504 HTTP status code when there is another node that the client knows about against which the request can be retried. The .NET client documentation summarizes the behaviour well.

Retries should also be implemented for the client, once ConnectionPool implementations that accept multiple urls have been implemented.

@russcam russcam added the enhancement New feature or request label Dec 20, 2019
@ghost
Copy link

ghost commented Oct 13, 2022

@russcam C# guy here, seemed like something good to pick up as I want to expand my Rust skills.

So, if there is only one node running Elasticsearch no retry should be attempted with a 502, 503, or 504?
Has the ConnectionPool implementations that you are speaking of been implemented?

@russcam
Copy link
Contributor Author

russcam commented Nov 27, 2022

Hi @WingZer0o,

That's correct. The multi node connection pool is in PR #189, which remains to be reviewed.

Since I no longer work at Elastic, I no longer have commit rights to this repository, so am unable to merge PRs. @swallez may be able to advise on the best course of action.

@ghost
Copy link

ghost commented Jan 6, 2023

@russcam No worries.

@shenshouer
Copy link

Doesn't support multi node connection pool at this crate ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants