Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove support for plain text request bodies #22751

Closed
jaymode opened this issue Jan 23, 2017 · 4 comments
Closed

Remove support for plain text request bodies #22751

jaymode opened this issue Jan 23, 2017 · 4 comments
Labels
:Core/Infra/REST API REST infrastructure and utilities >enhancement help wanted adoptme :Search/Search Search-related issues that do not fall into other categories

Comments

@jaymode
Copy link
Member

jaymode commented Jan 23, 2017

As a followup from #22691, I think we should consider removing support for the plain text bodies in the scroll APIs. Right now there is the option to use a request parameter, a json/yaml body, and a plain text body to specify the scroll id. These are the only APIs that support plain text and I do not think that it really buys us much to continue support for this.
@jaymode jaymode added :Core/Infra/REST API REST infrastructure and utilities :Scroll discuss labels Jan 23, 2017
@jaymode jaymode mentioned this issue Jan 23, 2017
Merged
@clintongormley
Copy link
Contributor

The analyze API also accepts plain text - this feature can be deprecated and removed.

@jaymode jaymode removed the discuss label Jan 27, 2017
@jaymode
Copy link
Member Author

jaymode commented Jan 27, 2017

Will deprecate these in 5.x and remove support in 6.0. Looks like the analyze api's support for plain text has already been removed in 6.0

@javanna javanna mentioned this issue May 5, 2017
Closed
@clintongormley clintongormley added :Search/Search Search-related issues that do not fall into other categories and removed :Scroll labels Feb 14, 2018
@talevy
Copy link
Contributor

talevy commented Mar 23, 2018

Pinging @elastic/es-search-aggs

@ebadyano
Copy link
Contributor

Fixed in #23146

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
:Core/Infra/REST API REST infrastructure and utilities >enhancement help wanted adoptme :Search/Search Search-related issues that do not fall into other categories
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@clintongormley @talevy @javanna @jaymode @ebadyano