Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When putting new dynamic templates, all existing templates are overwritten. #30274

Closed
jtibshirani opened this issue Apr 30, 2018 · 2 comments
Closed
Labels
>bug :Search Foundations/Mapping Index mappings, including merging and defining field types Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch v6.4.0 v7.0.0-beta1

Comments

@jtibshirani
Copy link
Contributor

Elasticsearch version (bin/elasticsearch --version): 6.2.3

Description of the problem including expected versus actual behavior:

Putting new mappings for dynamic_template overwrites all existing templates, even templates that the put mappings request does not mention. This behavior conflicts with what's described in the dynamic templates documentation:

New templates can be appended to the end of the list with the PUT mapping API. If a new template has the same name as an existing template, it will replace the old version.

If we're happy with the behavior described in the documentation, we should update the mapping merge logic to obey those semantics.

Steps to reproduce:

Please see the following gist: https://gist.github.com/jtibshirani/52d913410957b502d6037f02d1f1340a

@jtibshirani jtibshirani added >bug v7.0.0 v6.4.0 :Search Foundations/Mapping Index mappings, including merging and defining field types labels Apr 30, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search-aggs

@jtibshirani
Copy link
Contributor Author

It turns out this is a duplicate of #24853, where we decided to keep the current behavior. I opened #32890 to fix the documentation.

@jimczi jimczi added v7.0.0-beta1 and removed v7.0.0 labels Feb 7, 2019
@javanna javanna added the Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch label Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>bug :Search Foundations/Mapping Index mappings, including merging and defining field types Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch v6.4.0 v7.0.0-beta1
Projects
None yet
Development

No branches or pull requests

4 participants