Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MatrixStatsAggregatorTests#testTwoFields fails if aggs are reduced #37587

Closed
polyfractal opened this issue Jan 17, 2019 · 1 comment · Fixed by #38130
Closed

MatrixStatsAggregatorTests#testTwoFields fails if aggs are reduced #37587

polyfractal opened this issue Jan 17, 2019 · 1 comment · Fixed by #38130
Assignees
Labels
:Analytics/Aggregations Aggregations >test-failure Triaged test failures from CI

Comments

@polyfractal
Copy link
Contributor

As part of #36020, I accidentally stumbled onto a test bug. testTwoFields() fails if it is changed to searchAndReduce() instead of search(). The variance of the test's MultiPassStats object no longer matches the reduced matrix stats response.

It's not clear if this is because the mock MultiPassStats is doing something wrong, or if there's a bug when the matrix agg's reduction is buggy. MatrixStats uses a per-shard object (RunningStats) which is eventually converted into the final response object (MatrixStatsObject), at which point the correlation is calculated. It might be part of this process that is buggy, or perhaps how the stats objects are finalized after reduction.

@polyfractal polyfractal added :Analytics/Aggregations Aggregations >test-failure Triaged test failures from CI labels Jan 17, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-analytics-geo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/Aggregations Aggregations >test-failure Triaged test failures from CI
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants