Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update NodeToString Tests in Painless #51842

Closed
jdconrad opened this issue Feb 4, 2020 · 2 comments
Closed

Update NodeToString Tests in Painless #51842

jdconrad opened this issue Feb 4, 2020 · 2 comments
Assignees
@jdconrad
Labels
:Core/Infra/Scripting Scripting abstractions, Painless, and Mustache >refactoring Team:Core/Infra Meta label for core/infra team >test Issues or PRs that are addressing/adding tests

Comments

@jdconrad
Copy link
Contributor

jdconrad commented Feb 4, 2020

The NodeToString tests are no longer valid with the current Painless refactorings. However, since there are still some major upcoming structural changes to the user tree nodes, the tests are disabled for now. Once the majority of the structural changes are completed, the tests need to be updated.

Relates to #49869
@jdconrad jdconrad added >test Issues or PRs that are addressing/adding tests :Core/Infra/Scripting Scripting abstractions, Painless, and Mustache >refactoring labels Feb 4, 2020
@jdconrad jdconrad self-assigned this Feb 4, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (:Core/Infra/Scripting)

@jdconrad jdconrad mentioned this issue Feb 4, 2020
Merged
@rjernst rjernst added the Team:Core/Infra Meta label for core/infra team label May 4, 2020
@rjernst rjernst added the needs:triage Requires assignment of a team area label label Dec 3, 2020
@jdconrad
Copy link
Contributor Author

jdconrad commented Dec 9, 2020

This is no longer relevant as toString has been removed from the project in this way.

@jdconrad jdconrad closed this as completed Dec 9, 2020
@stu-elastic stu-elastic removed the needs:triage Requires assignment of a team area label label Jan 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jdconrad jdconrad

Labels
:Core/Infra/Scripting Scripting abstractions, Painless, and Mustache >refactoring Team:Core/Infra Meta label for core/infra team >test Issues or PRs that are addressing/adding tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@rjernst @jdconrad @elasticmachine @stu-elastic