Rewrite Inference yml tests for better clean up #61180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/ml-core (:ml) |
davidkyle
force-pushed
the
inference-yml-tests
branch
from
35a6fa6 to
8f14d8c
Compare
davidkyle
force-pushed
the
inference-yml-tests
branch
from
8f14d8c to
4b56dd2
Compare
davidkyle
added a commit
to davidkyle/elasticsearch
that referenced
this pull request
Aug 25, 2020
Inference processors asynchronously usage write stats to the .ml-stats index after they used. In tests the write can leak into the next test causing failures depending on which test follows. This change waits for the usage stats docs to be written at the end of the test
davidkyle
added a commit
that referenced
this pull request
Aug 27, 2020
Inference processors asynchronously usage write stats to the .ml-stats index after they used. In tests the write can leak into the next test causing failures depending on which test follows. This change waits for the usage stats docs to be written at the end of the test
davidkyle
added a commit
to davidkyle/elasticsearch
that referenced
this pull request
Sep 7, 2020
Inference processors asynchronously usage write stats to the .ml-stats index after they used. In tests the write can leak into the next test causing failures depending on which test follows. This change waits for the usage stats docs to be written at the end of the test
This was referenced Sep 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inference processors asynchronously write to the
.ml-statsindex when in use. During a test this write may occur after the tests has finished and the test teardown has deleted the indices meaning the index is recreated post test. Depending on which test follows it may cause a test failure later.This change rewrites the tests as
ESRestTestCaseand waits for the stats doc to be written at the end of the test.I've put the test in the qa::single-node-tests project
The 2 tests I found causing this failure are
Closes #60876
Closes #58841
UPDATE
There is another race in this test where you can put a ingest pipeline to load the model but then the ingest pipeline may be deleted before the model is loaded in which means it will not write the stats and the wait for stats assertion will fail. The fix is to perform inference on the model which ensures it is loaded