From 4d9dbb160edec8ea72fad2fbfcc5d22b5876b52a Mon Sep 17 00:00:00 2001
From: Przemyslaw Gomulka <przemyslaw.gomulka@elastic.co>
Date: Tue, 23 Feb 2021 11:19:38 +0100
Subject: [PATCH] Add RateLimitingFiltering to plaintext deprecation logs
 (#69190)

The #61474 changed the way we throttle deprecation logs, but missed a
filter to plaintext deprecation logs

closes #69188
---
 distribution/src/config/log4j2.properties         |  1 +
 .../common/logging/JsonLoggerTests.java           | 15 +++++++++++++++
 .../common/logging/json_layout/log4j2.properties  |  8 ++++++++
 3 files changed, 24 insertions(+)

diff --git a/distribution/src/config/log4j2.properties b/distribution/src/config/log4j2.properties
index b9ad71121165a..cd82c9b11af38 100644
--- a/distribution/src/config/log4j2.properties
+++ b/distribution/src/config/log4j2.properties
@@ -82,6 +82,7 @@ appender.deprecation_rolling_old.name = deprecation_rolling_old
 appender.deprecation_rolling_old.fileName = ${sys:es.logs.base_path}${sys:file.separator}${sys:es.logs.cluster_name}_deprecation.log
 appender.deprecation_rolling_old.layout.type = PatternLayout
 appender.deprecation_rolling_old.layout.pattern = [%d{ISO8601}][%-5p][%-25c{1.}] [%node_name]%marker %m%n
+appender.deprecation_rolling_old.filter.rate_limit.type = RateLimitingFilter
 
 appender.deprecation_rolling_old.filePattern = ${sys:es.logs.base_path}${sys:file.separator}${sys:es.logs.cluster_name}\
   _deprecation-%i.log.gz
diff --git a/qa/logging-config/src/test/java/org/elasticsearch/common/logging/JsonLoggerTests.java b/qa/logging-config/src/test/java/org/elasticsearch/common/logging/JsonLoggerTests.java
index 2a41b1b6c9a85..2b100acdf0a4b 100644
--- a/qa/logging-config/src/test/java/org/elasticsearch/common/logging/JsonLoggerTests.java
+++ b/qa/logging-config/src/test/java/org/elasticsearch/common/logging/JsonLoggerTests.java
@@ -28,6 +28,7 @@
 import org.junit.BeforeClass;
 
 import java.io.IOException;
+import java.nio.file.Files;
 import java.nio.file.Path;
 import java.util.List;
 import java.util.Map;
@@ -40,6 +41,7 @@
 import static org.hamcrest.Matchers.hasEntry;
 import static org.hamcrest.Matchers.hasKey;
 import static org.hamcrest.Matchers.not;
+import static org.hamcrest.core.IsEqual.equalTo;
 
 /**
  * This test confirms JSON log structure is properly formatted and can be parsed.
@@ -290,6 +292,9 @@ public void testDuplicateLogMessages() throws Exception {
                     )
                 );
             }
+
+            long oldStyleDeprecationLogCount = oldStyleDeprecationLogCount();
+            assertThat(oldStyleDeprecationLogCount, equalTo(1L));
         });
 
         // For the same key and different X-Opaque-ID should be multiple times per key/x-opaque-id
@@ -330,10 +335,20 @@ public void testDuplicateLogMessages() throws Exception {
                         )
                     )
                 );
+
+                long oldStyleDeprecationLogCount = oldStyleDeprecationLogCount();
+                assertThat(oldStyleDeprecationLogCount, equalTo(2L));
             }
         });
     }
 
+    private long oldStyleDeprecationLogCount() throws IOException {
+        try(Stream<String> lines = Files.lines(PathUtils.get(System.getProperty("es.logs.base_path"),
+            System.getProperty("es.logs.cluster_name") + "_deprecated.log"))){
+            return lines.count();
+        }
+    }
+
     private List<JsonLogLine> collectLines(Stream<JsonLogLine> stream) {
         return stream
             .skip(1)//skip the first line from super class
diff --git a/qa/logging-config/src/test/resources/org/elasticsearch/common/logging/json_layout/log4j2.properties b/qa/logging-config/src/test/resources/org/elasticsearch/common/logging/json_layout/log4j2.properties
index 708d39247491e..a3ad8d7d1e5ae 100644
--- a/qa/logging-config/src/test/resources/org/elasticsearch/common/logging/json_layout/log4j2.properties
+++ b/qa/logging-config/src/test/resources/org/elasticsearch/common/logging/json_layout/log4j2.properties
@@ -17,6 +17,13 @@ appender.deprecated.layout.type_name = deprecation
 appender.deprecated.layout.esmessagefields = x-opaque-id
 appender.deprecated.filter.rate_limit.type = RateLimitingFilter
 
+appender.deprecation_rolling_old.type = File
+appender.deprecation_rolling_old.name = deprecation_rolling_old
+appender.deprecation_rolling_old.fileName = ${sys:es.logs.base_path}${sys:file.separator}${sys:es.logs.cluster_name}_deprecated.log
+appender.deprecation_rolling_old.layout.type = PatternLayout
+appender.deprecation_rolling_old.layout.pattern = [%d{ISO8601}][%-5p][%-25c{1.}] [%node_name]%marker %m%n
+appender.deprecation_rolling_old.filter.rate_limit.type = RateLimitingFilter
+
 appender.deprecatedconsole.type = Console
 appender.deprecatedconsole.name = deprecatedconsole
 appender.deprecatedconsole.layout.type = ESJsonLayout
@@ -44,6 +51,7 @@ logger.deprecation.level = deprecation
 logger.deprecation.appenderRef.console.ref = console
 logger.deprecation.appenderRef.file.ref = file
 logger.deprecation.appenderRef.deprecation_rolling.ref = deprecated
+logger.deprecation.appenderRef.deprecation_rolling_old.ref = deprecation_rolling_old
 logger.deprecation.appenderRef.deprecatedconsole.ref = deprecatedconsole
 logger.deprecation.appenderRef.header_warning.ref = header_warning
 logger.deprecation.additivity = false