From 73fb8cc0b4a84c9b581736d25ed80712eac678aa Mon Sep 17 00:00:00 2001 From: Craig Rodrigues Date: Thu, 5 Oct 2023 19:37:06 -0700 Subject: [PATCH 1/2] Use non-deprecated URL: /api/security/saml/callback In https://github.com/elastic/kibana/blob/b33effa182bcb7c9620c5435ab252d8067732655/x-pack/plugins/security/server/routes/authentication/saml.ts#L27 /api/security/saml/callback is the correct URL, while /api/security/v1/saml is the deprecated URL. See also: https://github.com/elastic/kibana/issues/81733 Signed-off-by: Craig Rodrigues --- docs/changelog/98883.yaml | 6 ++++++ .../plugin/security/qa/smoke-test-all-realms/build.gradle | 2 +- 2 files changed, 7 insertions(+), 1 deletion(-) create mode 100644 docs/changelog/98883.yaml diff --git a/docs/changelog/98883.yaml b/docs/changelog/98883.yaml new file mode 100644 index 0000000000000..ee572d6f74e92 --- /dev/null +++ b/docs/changelog/98883.yaml @@ -0,0 +1,6 @@ +pr: 99983 +summary: Use non-deprecated URL: /api/security/saml/callback in SAML smoketests +area: Authorization +type: enhancement +issues: + - 99986 diff --git a/x-pack/plugin/security/qa/smoke-test-all-realms/build.gradle b/x-pack/plugin/security/qa/smoke-test-all-realms/build.gradle index ca33b61de4ca5..d80dbe14e6ccb 100644 --- a/x-pack/plugin/security/qa/smoke-test-all-realms/build.gradle +++ b/x-pack/plugin/security/qa/smoke-test-all-realms/build.gradle @@ -62,7 +62,7 @@ testClusters.matching { it.name == 'javaRestTest' }.configureEach { setting 'xpack.security.authc.realms.saml.saml5.idp.metadata.path', 'saml-metadata.xml' setting 'xpack.security.authc.realms.saml.saml5.idp.entity_id', 'http://idp.example.com/' setting 'xpack.security.authc.realms.saml.saml5.sp.entity_id', 'http://kibana.example.net/' - setting 'xpack.security.authc.realms.saml.saml5.sp.acs', 'http://kibana.example.net/api/security/v1/saml' + setting 'xpack.security.authc.realms.saml.saml5.sp.acs', 'http://kibana.example.net/api/security/saml/callback' setting 'xpack.security.authc.realms.saml.saml5.attributes.principal', 'uid' // - Kerberos (configured but won't work because we don't want external fixtures in this test suite) setting 'xpack.security.authc.realms.kerberos.kerb6.order', '6' From 8b0ba0a74064b0bcfbf8dfed898d6d86d1d5582f Mon Sep 17 00:00:00 2001 From: Athena Brown Date: Thu, 12 Oct 2023 11:17:16 -0600 Subject: [PATCH 2/2] Fix summary Our tooling doesn't like slashes in these summary fields, so I adjusted the name of the patch slightly to avoid them. --- docs/changelog/98883.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/changelog/98883.yaml b/docs/changelog/98883.yaml index ee572d6f74e92..a8525a432d142 100644 --- a/docs/changelog/98883.yaml +++ b/docs/changelog/98883.yaml @@ -1,5 +1,5 @@ pr: 99983 -summary: Use non-deprecated URL: /api/security/saml/callback in SAML smoketests +summary: Use non-deprecated SAML callback URL in SAML smoketests area: Authorization type: enhancement issues: