From c6016bf5fcf16ce992fd4fd96ce01b16097d61ce Mon Sep 17 00:00:00 2001 From: Cee Chen Date: Thu, 27 Jul 2023 16:43:46 -0700 Subject: [PATCH] Remove final low-usage `$euiHeader` Sass variables + delete remaining header scss files - `$euiHeaderHeight` Sass variables have too much usage in Kibana etc., so keeping those for now - same for header Sass mixin --- src/components/header/_index.scss | 0 src/components/index.scss | 1 - src/global_styling/variables/_header.scss | 6 ------ upcoming_changelogs/7005.md | 2 ++ 4 files changed, 2 insertions(+), 7 deletions(-) delete mode 100644 src/components/header/_index.scss diff --git a/src/components/header/_index.scss b/src/components/header/_index.scss deleted file mode 100644 index e69de29bb2d..00000000000 diff --git a/src/components/index.scss b/src/components/index.scss index 55d31f50edc..30610b4f918 100644 --- a/src/components/index.scss +++ b/src/components/index.scss @@ -10,7 +10,6 @@ @import 'drag_and_drop/index'; @import 'empty_prompt/index'; @import 'form/index'; -@import 'header/index'; @import 'key_pad_menu/index'; @import 'markdown_editor/index'; @import 'notification/index'; diff --git a/src/global_styling/variables/_header.scss b/src/global_styling/variables/_header.scss index d3fa43e9ee7..df68553c62e 100644 --- a/src/global_styling/variables/_header.scss +++ b/src/global_styling/variables/_header.scss @@ -1,9 +1,3 @@ -// Themeable colors -$euiHeaderBackgroundColor: $euiColorEmptyShade !default; - -// Layout vars $euiHeaderHeight: $euiSizeXXL + $euiSizeS !default; -$euiHeaderChildSize: $euiSizeXXL !default; - // Use the following variable in other components to afford for the fixed header $euiHeaderHeightCompensation: $euiHeaderHeight !default; diff --git a/upcoming_changelogs/7005.md b/upcoming_changelogs/7005.md index 12cd8f15d03..16629a8f250 100644 --- a/upcoming_changelogs/7005.md +++ b/upcoming_changelogs/7005.md @@ -12,3 +12,5 @@ - Converted `EuiHeaderAlert` to Emotion; Removed unused `.euiHeaderAlert__dismiss` CSS - Converted `EuiHeaderSection`, `EuiHeaderSectionItem`, and `EuiHeaderSectionItemButton` to Emotion - Converted `EuiHeaderLinks` and `EuiHeaderLink` to Emotion; Removed `$euiHeaderLinksGutterSizes` Sass variables +- Removed `$euiHeaderBackgroundColor` Sass variable; use `$euiColorEmptyShade` instead +- Removed `$euiHeaderChildSize` Sass variable; use `$euiSizeXXL` instead