Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add active prop to EuiOutsideClickDetector #1526

Closed
chandlerprall opened this issue Feb 5, 2019 · 3 comments · Fixed by #1527
Closed

Add active prop to EuiOutsideClickDetector #1526

chandlerprall opened this issue Feb 5, 2019 · 3 comments · Fixed by #1527
Assignees

Comments

@chandlerprall
Copy link
Contributor

EuiOutsideClickDetector should be pausable based on an active prop. EuiPopover should use this to pause its click detector when the popover is closed.

@thompsongl
Copy link
Contributor

thompsongl commented Feb 5, 2019

Is this different than the isDisabled prop that EuiOutsideClickDetector already accepts (and uses to "exit" the outside click handler?

@chandlerprall
Copy link
Contributor Author

Heh. Nope. Let's use isDisabled from the popover then :)

@thompsongl
Copy link
Contributor

😄 That's what I figured. EuiColorPicker has the same problem as EuiPopover here, so I'll address both.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants