-
Notifications
You must be signed in to change notification settings - Fork 842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add height restriction option for EuiImage #1554
Comments
Another nudge to @miukimiu since she's in this code already with #2287 Might be an easy prop to add. |
Anyone working on this ? |
Hi @nik72619c, I must have missed this while working on #2287. Not sure if @andreadelrio is going to work on this. I'm seeing her assigned to this task. But do you want to help? |
yeah sure ! |
Just wanted some clarity on the fact that as there exists a class for setting the full width like |
I think by default the height would adjust based upon the width and a "full height" isn't needed. Likely we just need a "max height" that would restrict the width if needed. In all cases the images original ratio should be maintained. |
how much should be the "max height" ? |
Talking about this with @cchaos we decided it likely makes sense that the It would also be nice if the |
Is anyone working on this issue? |
Removing @andreadelrio from the assignee. As the last comment was 5 days ago, I'm going to keep this un-assigned until the next time someone asks for it. |
The EuiImage component has the size parameter to set the width of an image, but it isn't possible to controll the height (or maximum height) which may come in handy if user supplied images with unkown aspect ratio are displayed using this component (e.g. elastic/kibana#30654)
Open for discussion how exactly this should look like.
The text was updated successfully, but these errors were encountered: