Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable keyofStringsOnly TS configuration #1725

Closed
chandlerprall opened this issue Mar 13, 2019 · 3 comments
Closed

Disable keyofStringsOnly TS configuration #1725

chandlerprall opened this issue Mar 13, 2019 · 3 comments
Assignees
@thompsongl
Labels
chore typescript

Comments

@chandlerprall
Copy link
Contributor

Kibana set "keyofStringsOnly": true to keep compatibility with EUI pre-TS 2.9.2. EUI has now upgraded and kept the keyofStringsOnly setting. We should remove it from EUI and then from Kibana's & Cloud UI's configs.
@thompsongl thompsongl self-assigned this Apr 9, 2019
@thompsongl thompsongl mentioned this issue Apr 9, 2019
Merged
2 tasks
@thompsongl
Copy link
Contributor

Kibana update PR: elastic/kibana#35112

@thompsongl
Copy link
Contributor

cloud-ui update PR: elastic/cloud#31231

@thompsongl
Copy link
Contributor

Both PRs merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thompsongl thompsongl

Labels
chore typescript
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chandlerprall @thompsongl