Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tooltip misplaced when its content change #1734

Closed
markov00 opened this issue Mar 15, 2019 · 1 comment
Closed

Tooltip misplaced when its content change #1734

markov00 opened this issue Mar 15, 2019 · 1 comment
Assignees

Comments

@markov00
Copy link
Member

markov00 commented Mar 15, 2019

Similar to #996

We have this PR elastic/kibana#33107 where we change the text and the icon of a button with a tooltip on each click event (https://github.com/elastic/kibana/pull/33107/files#diff-ff73d44eb7d5b75815d6758b0ff0abd4R93).
The effect when you continue to click on the button is the following:
Mar-15-2019 09-14-32

cc @chandlerprall as you previously fixed this

Steps to reproduce:

note if you add a second series it behave correctly:
Mar-15-2019 09-38-31

@markov00 markov00 changed the title Tooltip misplaced when it content change Tooltip misplaced when its content change Mar 15, 2019
@thompsongl
Copy link
Contributor

thompsongl commented Mar 18, 2019

I see a couple things:

  1. This is an available horizontal space problem, possibly left area only. (i.e., change padding on the .tvbSeriesEditor panel to 8px 16px and the problem goes away). Adding a second series fixes it because 2 more icons are added to the row.
  2. The position calculation is different on initial render vs. subsequent renders with the same data (i.e., the 'Temporarily Disable' tooltip is a different size after two clicks)

Janky test case to illustrate:
Kapture 2019-03-18 at 17 16 36

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants