-
Notifications
You must be signed in to change notification settings - Fork 842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Discuss] If aria-labels
are supplied, add them to the title
attribute as well?
#2021
Comments
From my perspective, the best way would be to fill the title with the aria-label's value if the title is not provided. At the same time let it overrides with the separately provided value. |
Inclined to close this. Titles and aria-labels are very different things. They sometimes are the same, and may even often be the same, but not always. |
Agreed that they're not always the same, which is why we'd allow the title to be overridden. But more often than not, only aria-label is supplied or both are supplied and they are the same. I'm mostly thinking about icons and icon buttons that never have textual context and could really use |
This one has stagnated because our current implementation of icons which use SVG do not support the |
Should we even be using |
I find our tooltips to be too intrusive to use the as often as we add |
My biggest concern with supporting the In which case, I'm back to thinking that custom tooltips are the way to solve this (even if it means a new "subtle" flavor of EuiToolTip. Sorry if this concern is out of scope of what you originally wanted to discuss - don't mean to hijack your thread. |
See #4040 as related |
Closing in favor of a Meta discussion around EuiTooltip flexibility which I've included a link to this discussion but needs to be a part of a greater effort. |
There's a lot of duplication on the consumer side to supply both a
title
andaria-label
especially on EuiButtonIcon.Is there any way we can help out the consumer but auto-providing one or the other?
The text was updated successfully, but these errors were encountered: