Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EuiSelectable] Types for option value #2367

Closed
flash1293 opened this issue Sep 24, 2019 · 1 comment
Closed

[EuiSelectable] Types for option value #2367

flash1293 opened this issue Sep 24, 2019 · 1 comment
Labels
typescript

Comments

@flash1293
Copy link
Contributor

This is related to #2078 Currently an EuiSelectable only takes a fixed interface Option https://github.com/elastic/eui/blob/master/src/components/selectable/types.tsx

Like in combo boxes there are cases where it would be beneficial to put custom payload in the option to use it in a custom renderOption or to react to a selection in onChange (e.g. https://github.com/elastic/kibana/pull/46350/files#diff-b248fbad33abd970675562f8b344c6b1R105)
@flash1293 flash1293 changed the title Typescript: Types for selectable option value Typescript: Types for EuiSelectable option value Sep 24, 2019
@cchaos cchaos changed the title Typescript: Types for EuiSelectable option value [EuiSelectable] Types for option value Sep 20, 2020
@thompsongl
Copy link
Contributor

This was resolved by work in #3800 and #3983

The option interface is extendable via type generic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
typescript
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@cchaos @flash1293 @thompsongl