Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EuiCodeBlock requires a DOM implementation when the component is created #3156

Closed
pugnascotia opened this issue Mar 24, 2020 · 2 comments · Fixed by #3405
Closed

EuiCodeBlock requires a DOM implementation when the component is created #3156

pugnascotia opened this issue Mar 24, 2020 · 2 comments · Fixed by #3405

Comments

@pugnascotia
Copy link
Contributor

EuiCodeBlockImpl in src/components/code/_code_block.tsx expects to be able to call document.createElement while the class instance is being constructed. This makes it impossible (from a practical POV) to use in the Next starter. This component should only be creating DOM nodes in an appropriate lifecycle function.

@tushar22-tg
Copy link

Is it really a gsoc issue?
why isn't this mentioned it in https://github.com/elastic/gsoc

or is it a bug that selected GSoC candidates should solve during there summer time?

@chandlerprall
Copy link
Contributor

chandlerprall commented Mar 24, 2020

@tushar22-tg we use these Issues to track all bugs, feature requests, and other ideas. We have designers and engineers who work full time in this repo, and pull from this same list of issues. A couple of the ideas are big enough for GSoC, and we've compiled them at https://github.com/elastic/gsoc#ideas - as EUI is an open source library, everyone is free to browse our issues and create PRs addressing [nearly] anything listed here, please see https://github.com/elastic/eui/blob/master/CONTRIBUTING.md for more details.

Edit: After replying, I noticed this had the GSoC label. Swapped that out for good first issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants