-
Notifications
You must be signed in to change notification settings - Fork 841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EuiFormRow] With difficult components #3218
Comments
🤔 Interesting idea. Would love to see a POC |
Yes, @chandlerprall, we would all love to see a POC 😆 |
👋 Hey there. This issue hasn't had any activity for 180 days. We'll automatically close it if that trend continues for another week. If you feel this issue is still valid and needs attention please let us know with a comment. |
👋 Hey there. This issue hasn't had any activity for 180 days. We'll automatically close it if that trend continues for another week. If you feel this issue is still valid and needs attention please let us know with a comment. |
👋 Hi there - this issue hasn't had any activity in 6 months. If the EUI team has not explicitly expressed that this is something on our roadmap, it's unlikely that we'll pick this issue up. We would sincerely appreciate a PR/community contribution if this is something that matters to you! If not, and there is no further activity on this issue for another 6 months (i.e. it's stale for over a year), the issue will be auto-closed. |
❌ Per our previous message, this issue is auto-closing after having been open and inactive for a year. If you strongly feel this is still a high-priority issue, or are interested in contributing, please leave a comment or open a new issue linking to this one for context. |
EuiFormRow passes down the
id
aninput
element should take on to wire up EuiFormRow's<label>
correctly.But there are several cases where this breaks down:
id
never makes it to the<input />
<input />
elements (like dual input Range Sliders because you can't have multiple ids on a pagehasChildLabel
prop on EuiFormRow, is with wrapped<input />
elements that already have an applied labelsearchable
EuiSelectable, the<input />
needs the passed inid
but also an associated element (aul
in this case) needs a reversearia-describedby
set to thelabel
'sid
.@chandlerprall suggested that this might be solved by somehow using React's context to do all this...
Kind of related to #2493
The text was updated successfully, but these errors were encountered: