Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiFormRow] With difficult components #3218

Closed
myasonik opened this issue Apr 1, 2020 · 6 comments
Closed

[EuiFormRow] With difficult components #3218

myasonik opened this issue Apr 1, 2020 · 6 comments
Labels
accessibility ⚠️ needs spec Should be groomed by the EUI team every week to ensure a spec is added stale-issue stale-issue-closed

Comments

@myasonik
Copy link
Contributor

myasonik commented Apr 1, 2020

EuiFormRow passes down the id an input element should take on to wire up EuiFormRow's <label> correctly.

But there are several cases where this breaks down:

  • [EuiFormRow] doesn't always wire up the label and input #3037 describes a case where if the form control isn't built as expected by EuiFormRow and so the id never makes it to the <input />
  • Another issue is what to do if there are multiple <input /> elements (like dual input Range Sliders because you can't have multiple ids on a page
  • Another issue, that's been somewhat hastily solved by the hasChildLabel prop on EuiFormRow, is with wrapped <input /> elements that already have an applied label
  • And, the impetus for making this issue, for the case of a searchable EuiSelectable, the <input /> needs the passed in id but also an associated element (a ul in this case) needs a reverse aria-describedby set to the label's id.

@chandlerprall suggested that this might be solved by somehow using React's context to do all this...

Kind of related to #2493

@cchaos
Copy link
Contributor

cchaos commented Apr 1, 2020

🤔 Interesting idea. Would love to see a POC

@myasonik
Copy link
Contributor Author

myasonik commented Apr 2, 2020

Yes, @chandlerprall, we would all love to see a POC 😆

@cchaos cchaos changed the title Using [EuiFormRow] with difficult components [EuiFormRow] With difficult components Sep 20, 2020
@cchaos cchaos added the ⚠️ needs spec Should be groomed by the EUI team every week to ensure a spec is added label Sep 20, 2020
@github-actions
Copy link

👋 Hey there. This issue hasn't had any activity for 180 days. We'll automatically close it if that trend continues for another week. If you feel this issue is still valid and needs attention please let us know with a comment.

@github-actions
Copy link

👋 Hey there. This issue hasn't had any activity for 180 days. We'll automatically close it if that trend continues for another week. If you feel this issue is still valid and needs attention please let us know with a comment.

@github-actions
Copy link

👋 Hi there - this issue hasn't had any activity in 6 months. If the EUI team has not explicitly expressed that this is something on our roadmap, it's unlikely that we'll pick this issue up. We would sincerely appreciate a PR/community contribution if this is something that matters to you! If not, and there is no further activity on this issue for another 6 months (i.e. it's stale for over a year), the issue will be auto-closed.

@github-actions
Copy link

❌ Per our previous message, this issue is auto-closing after having been open and inactive for a year. If you strongly feel this is still a high-priority issue, or are interested in contributing, please leave a comment or open a new issue linking to this one for context.

@cee-chen cee-chen closed this as not planned Won't fix, can't repro, duplicate, stale Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility ⚠️ needs spec Should be groomed by the EUI team every week to ensure a spec is added stale-issue stale-issue-closed
Projects
None yet
Development

No branches or pull requests

3 participants