Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for common layout pattern often used in Kibana #3743

Closed
efreeti opened this issue Jul 15, 2020 · 6 comments · Fixed by #4525
Closed

Add support for common layout pattern often used in Kibana #3743

efreeti opened this issue Jul 15, 2020 · 6 comments · Fixed by #4525

Comments

@efreeti
Copy link

efreeti commented Jul 15, 2020

In security application (Administration tab) my team is trying to migrate to a new page layout that looks something like this:

image

This is not the first instance of such page layout - it's the same in Observability -> Overview and some Ingest Management pages. So I was playing around with it a bit and checked how others do it. But roughly speaking there is no support from EUI for such layout, which would be nice to have for example in the EuiPage component or I'm sure you have better ideas where it could be incorporated. I'm pretty new to elastic so I'm not yet very versed into the processes here, but I noticed that right now every team does it in it's own way and most of them I would say a bit hacky. Same applies to my changeset (it's a draft but your comments are very welcome) - elastic/kibana#71687.

I would like to trigger discussion about supporting such layout in EUI (I'm more than happy to create initial PR based on your advises where this could go). Our designers are definitely pushing towards having most views in Security plugin to use this layout.

@kevinlog
Copy link

@bfishel @lindseypoli @marrasherrier @caitlinbetz @paul-tavares @parkiino FYI - this issue on EUI would officially support the designs that we are looking at rolling out across the Security app. We should give this some likes/attention

@cchaos
Copy link
Contributor

cchaos commented Jul 15, 2020

@hbharding @lindseypoli @jmiller263 You three have been working on page layout patterns. Looks like we'll need a spec for this specific layout pretty quickly. Could you all consolidate your needs into a single mock/spec?

@hbharding
Copy link
Contributor

hbharding commented Jul 15, 2020

Happy to! I think there are a lot of places throughout Kibana where this kind of layout could be used. For planning purposes, when would this new component be needed, and when would we ideally deliver specs by?

@efreeti
Copy link
Author

efreeti commented Jul 17, 2020

If it would be up to me I'd say we need it yesterday ;) but I'm not sure who is determining the urgency of these kind of things.

@cchaos
Copy link
Contributor

cchaos commented Jul 17, 2020

Haha, I think the more helpful ask then is in what Kibana release are you planning to have this layout?

@efreeti
Copy link
Author

efreeti commented Jul 29, 2020

Sorry for the late reply, I think it might end up in 7.10, some teams from security already do this layout in their own way.

@cchaos cchaos changed the title [Discuss] Add support for common layout pattern often used in Kibana Add support for common layout pattern often used in Kibana Sep 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants