Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DATA Grid] Switch Header columns focus handling to native #3872

Closed
kertal opened this issue Aug 6, 2020 · 2 comments
Closed

[DATA Grid] Switch Header columns focus handling to native #3872

kertal opened this issue Aug 6, 2020 · 2 comments
Assignees

Comments

@kertal
Copy link
Member

kertal commented Aug 6, 2020

When working on #3087 I've experienced that the current handling of header columns doesn't work well when there are multiple focusable elements in the header. Navigating with the tab key, I expected that I could navigate all focusable elements with tab key, but I could just navigate to the first button, the next tab switched to the "Rows per page element". Removing the header columns from focus management, would simplify the code a lot, make it less vulnerable to errors (it's currently broken in master), and I think tab navigation would work better. The downside is that you can no longer navigate from body to header with arrow keys (Personally I'd say use tabs for configuration, arrows for data).

That's the current behavior:
image

An here's the one switching to tabs
image

@myasonik
Copy link
Contributor

myasonik commented Aug 6, 2020

I don't think this is something we can safely change. With such a complex component and with the absolute lack of testing that we do with real users, the best we can do is stick the best practices and the spec which this would go against (to the best of my knowledge and research).

While switching to native focus handling might make for simpler code, it will completely break screen reader expectations making the grid much harder to navigate and understand.

There's a separate issue (#3860) open for fixing the table header navigation.

@kertal
Copy link
Member Author

kertal commented Aug 18, 2020

I see, and we can't detect screenreaders, right? np. closing this

@kertal kertal closed this as completed Aug 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants