You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Although popular, highlight.js is pretty slow and getting a little old in its methodology. I often see it fail in complex syntax blocks and it'd be nice if we had something that provided virtualization out of the gate.
I'd like to look into replacing it with react-syntax-highlighter which is backed by Prism JS (which I have some love and familiarity with) and comes with virtualization (which would close #1208).
I can give this a shot myself, but please give a yell if anything looks out of sort from that dependency. The bulk of the work I think will be transferring our styling over.
The text was updated successfully, but these errors were encountered:
When using EUI, highlight.js is currently one of the dependencies really bloating your bundle sizes, even if you never use EuiCodeBlock in your project. While I know that there is some long term work for modularizing EUI better to prevent such things I wonder, if we could (as a quick win), make react-syntax-highlighter/Prism JS a peer dependency and use async import when required, so that not the full syntax highlighter will be bundled into every project that uses EUI?
👋 Hey there. This issue hasn't had any activity for 180 days. We'll automatically close it if that trend continues for another week. If you feel this issue is still valid and needs attention please let us know with a comment.
Although popular, highlight.js is pretty slow and getting a little old in its methodology. I often see it fail in complex syntax blocks and it'd be nice if we had something that provided virtualization out of the gate.
I'd like to look into replacing it with react-syntax-highlighter which is backed by Prism JS (which I have some love and familiarity with) and comes with virtualization (which would close #1208).
I can give this a shot myself, but please give a yell if anything looks out of sort from that dependency. The bulk of the work I think will be transferring our styling over.
The text was updated successfully, but these errors were encountered: