You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Originally we had restricted the use of both href and onClick on the same element mainly because of accessibility and semantics. We have started lightening up on these restrictions because we now know that routing SPA's like React-router sometimes needs both in order to support right clicking. We've then moved towards allowing both but we have a Eslint warning for consumers to acknowledge that this is in fact what they want.
So, good catch, we should open this component up to allow both.
When the
href
prop is provided for the<EuiBadge>
, theonClick
prop is excluded, may I know is this the design choice or it is a bug?Here is the code snippet that exclude the
onClick
prop:eui/src/components/badge/badge.tsx
Lines 228 to 234 in 93fc2ff
The text was updated successfully, but these errors were encountered: