Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate EuiLink into the docs' routing #4052

Closed
chandlerprall opened this issue Sep 18, 2020 · 3 comments
Closed

Integrate EuiLink into the docs' routing #4052

chandlerprall opened this issue Sep 18, 2020 · 3 comments
Labels
documentation Issues or PRs that only affect documentation - will not need changelog entries feature request

Comments

@chandlerprall
Copy link
Contributor

chandlerprall commented Sep 18, 2020 •
edited
Loading

We do not prescribe what routing tech/framework to use, but because our documentation uses react-router, its Link component is used in our documentation. This also has negative impact on the code sandbox demos.

  • Locate uses of react-router's Link component
  • Replace with EuiLink

Originally posted by @chandlerprall in #4046 (comment)
@chandlerprall chandlerprall added documentation Issues or PRs that only affect documentation - will not need changelog entries feature request labels Sep 18, 2020
@chandlerprall chandlerprall self-assigned this Sep 18, 2020
@chandlerprall chandlerprall mentioned this issue Oct 7, 2020
Merged
3 tasks
@elizabetdev elizabetdev mentioned this issue Nov 17, 2020
Closed
@github-actions
Copy link

👋 Hey there. This issue hasn't had any activity for 180 days. We'll automatically close it if that trend continues for another week. If you feel this issue is still valid and needs attention please let us know with a comment.

@chandlerprall
Copy link
Contributor Author

This is still valid, and is now unblocked

@daveyholler
Copy link
Contributor

Closing for now. Things appear to be working acceptably.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Issues or PRs that only affect documentation - will not need changelog entries feature request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@chandlerprall @cchaos @daveyholler