Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiButtonGroup] Compressed selected button is hard to see #4105

Closed
monfera opened this issue Oct 4, 2020 · 2 comments · Fixed by #4142
Closed

[EuiButtonGroup] Compressed selected button is hard to see #4105

monfera opened this issue Oct 4, 2020 · 2 comments · Fixed by #4142
Assignees
Labels

Comments

@monfera
Copy link

monfera commented Oct 4, 2020

The background-color for .euiButtonGroup--compressed .euiButtonGroup__button--selected is set to a very light grey #e9edf3, while the equivalent non-compressed, eg. buttonSize="s" equivalent has a way more contrasty anthracite color #69707d. Is it possible to make the compressed version darker? It'd also need the color to be flipped to white.

Current and proposed:
image
image

@monfera monfera added accessibility accessibility - WCAG A Level A WCAG Accessibility Criteria labels Oct 4, 2020
@snide
Copy link
Contributor

snide commented Oct 5, 2020

Proposed is currently what the amsterdam theme has. I know that we'd originally gone lighter because the compressed usage almost always had high form density (usually within panels) and was distracting against the main content.

image

@monfera
Copy link
Author

monfera commented Oct 8, 2020

Thanks @snide I didn't know, looks crisp! If the baseline theme isn't deprecated and the user has it by default or can switch to it, maybe a contrasty yet lightweight "selected" frame can be added around the icon, though it has tradeoffs that may have caused a rejection of this already

@elizabetdev elizabetdev self-assigned this Oct 14, 2020
@cchaos cchaos changed the title [minor] In a compressed EuiButtonGroup, the selected button has a hard to see background color (v27.0.0) [EuiButtonGroup] Compressed selected button is hard to see Oct 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants