-
Notifications
You must be signed in to change notification settings - Fork 842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate new XY Chart theme value labels styling #4267
Comments
I'm also linking this issue elastic/elastic-charts#886 where we discussing the use of the value labels. |
👋 Hey there. This issue hasn't had any activity for 180 days. We'll automatically close it if that trend continues for another week. If you feel this issue is still valid and needs attention please let us know with a comment. |
❌ We're automatically closing this issue due to lack of activity. Please comment if you feel this was done in error. |
Ugh, this issue should have been skipped because it has an assignee. |
Following up on this since we just got a user asking about it. Seems like we've made a decision to reduce the default border, but it's not implemented yet? |
@wylieconlon I'll prioritize this issue. The decision is to not use the border (or yes, to use it but very discrete). Borders should be used when we have multiple background colors. For instance, a label on top of a map. When we only have one background color we can improve the contrast of the label so the border is not necessary. It only creates more distractions. |
Since v.24.0.0 elastic-charts ships an improved value labels feature, currently merged in Lens with a theme customization.
As suggested by @markov00 this theme customization should be integrated into EUI.
The text was updated successfully, but these errors were encountered: